summary refs log tree commit diff
path: root/drivers/media/video/bw-qcam.c
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-07-04 11:11:42 -0300
committerMauro Carvalho Chehab <mchehab@redhat.com>2011-07-27 17:55:55 -0300
commitee893e9adccd7dc22a6cfc5d4f49e7dd0baead0c (patch)
tree5df6b9ceba36687c3e999089d8b6a93fd45d2f0a /drivers/media/video/bw-qcam.c
parent37f9619dd5df9f1c9878ac53e27033519b8760ec (diff)
downloadlinux-ee893e9adccd7dc22a6cfc5d4f49e7dd0baead0c.tar.gz
[media] drivers/media/video: add missing kfree
Free the recently allocated qcam in each case.

The semantic match that finds this problem is as follows:

// <smpl>
@r@
identifier x;
@@

kfree(x)

@@
identifier r.x;
expression E1!=0,E2,E3,E4;
statement S;
@@

(
if (<+...x...+>) S
|
if (...) { ... when != kfree(x)
               when != if (...) { ... kfree(x); ... }
               when != x = E3
* return E1;
}
... when != x = E2
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/video/bw-qcam.c')
-rw-r--r--drivers/media/video/bw-qcam.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c
index 2fc998e9b2f7..f09df9dffaae 100644
--- a/drivers/media/video/bw-qcam.c
+++ b/drivers/media/video/bw-qcam.c
@@ -893,6 +893,7 @@ static struct qcam *qcam_init(struct parport *port)
 
 	if (v4l2_device_register(NULL, v4l2_dev) < 0) {
 		v4l2_err(v4l2_dev, "Could not register v4l2_device\n");
+		kfree(qcam);
 		return NULL;
 	}