summary refs log tree commit diff
path: root/drivers/media/radio/wl128x
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-03-06 02:27:43 -0500
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>2019-03-19 16:38:37 -0400
commitef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 (patch)
tree42d5d32cbe1891b0678eb0d77f955659a211d545 /drivers/media/radio/wl128x
parentc1a65ebd05a9a6b9ae753fbc9f6ed2a8f0f4f09f (diff)
downloadlinux-ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3.tar.gz
media: wl128x: Fix an error code in fm_download_firmware()
We forgot to set "ret" on this error path.

Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Diffstat (limited to 'drivers/media/radio/wl128x')
-rw-r--r--drivers/media/radio/wl128x/fmdrv_common.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 3c8987af3772..1614809f7d35 100644
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -1268,8 +1268,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name)
 
 		switch (action->type) {
 		case ACTION_SEND_COMMAND:	/* Send */
-			if (fmc_send_cmd(fmdev, 0, 0, action->data,
-						action->size, NULL, NULL))
+			ret = fmc_send_cmd(fmdev, 0, 0, action->data,
+					   action->size, NULL, NULL);
+			if (ret)
 				goto rel_fw;
 
 			cmd_cnt++;