diff options
| author | Ezequiel Garcia <elezegarcia@gmail.com> | 2012-10-23 15:57:19 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-12-27 19:01:51 -0200 |
| commit | b52377475ae9dca21bcb1ae8ec0936fbae8595b2 (patch) | |
| tree | d6f950c5723d779ab3cdc7444739115de7233ebf /drivers/media/pci/cx88/cx88-i2c.c | |
| parent | 01a5cbebce7bca910f50dff19b05177c2c8a8a76 (diff) | |
| download | linux-b52377475ae9dca21bcb1ae8ec0936fbae8595b2.tar.gz | |
[media] cx88: Replace memcpy with struct assignment
This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it's type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @@ identifier struct_name; struct struct_name to; struct struct_name from; expression E; @@ -memcpy(&(to), &(from), E); +to = from; // </smpl> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'drivers/media/pci/cx88/cx88-i2c.c')
| -rw-r--r-- | drivers/media/pci/cx88/cx88-i2c.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/media/pci/cx88/cx88-i2c.c b/drivers/media/pci/cx88/cx88-i2c.c index de0f1af74e41..cf2d69615838 100644 --- a/drivers/media/pci/cx88/cx88-i2c.c +++ b/drivers/media/pci/cx88/cx88-i2c.c @@ -139,8 +139,7 @@ int cx88_i2c_init(struct cx88_core *core, struct pci_dev *pci) if (i2c_udelay<5) i2c_udelay=5; - memcpy(&core->i2c_algo, &cx8800_i2c_algo_template, - sizeof(core->i2c_algo)); + core->i2c_algo = cx8800_i2c_algo_template; core->i2c_adap.dev.parent = &pci->dev; |