summary refs log tree commit diff
path: root/drivers/md/dm-snap.c
diff options
context:
space:
mode:
authorMikulas Patocka <mpatocka@redhat.com>2015-02-17 14:30:53 -0500
committerMike Snitzer <snitzer@redhat.com>2015-02-18 09:41:19 -0500
commit2bec1f4a8832e74ebbe859f176d8a9cb20dd97f4 (patch)
treeb9d1da979b02b7f026e4b1db91ccc6022096567b /drivers/md/dm-snap.c
parentb3c5fd3052492f1b8d060799d4f18be5a5438add (diff)
downloadlinux-2bec1f4a8832e74ebbe859f176d8a9cb20dd97f4.tar.gz
dm: fix a race condition in dm_get_md
The function dm_get_md finds a device mapper device with a given dev_t,
increases the reference count and returns the pointer.

dm_get_md calls dm_find_md, dm_find_md takes _minor_lock, finds the
device, tests that the device doesn't have DMF_DELETING or DMF_FREEING
flag, drops _minor_lock and returns pointer to the device. dm_get_md then
calls dm_get. dm_get calls BUG if the device has the DMF_FREEING flag,
otherwise it increments the reference count.

There is a possible race condition - after dm_find_md exits and before
dm_get is called, there are no locks held, so the device may disappear or
DMF_FREEING flag may be set, which results in BUG.

To fix this bug, we need to call dm_get while we hold _minor_lock. This
patch renames dm_find_md to dm_get_md and changes it so that it calls
dm_get while holding the lock.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'drivers/md/dm-snap.c')
0 files changed, 0 insertions, 0 deletions