summary refs log tree commit diff
path: root/drivers/leds/leds-lp5523.c
diff options
context:
space:
mode:
authorSachin Kamat <sachin.kamat@linaro.org>2012-11-20 01:59:01 -0800
committerBryan Wu <cooloney@gmail.com>2012-11-26 14:43:55 -0800
commit5ebab74a711388fc30e6d839eee79aa06d1ce0af (patch)
tree7efd3f5dfdb6f9f1ad44cd574e53e58042cbd7bf /drivers/leds/leds-lp5523.c
parent313e8b50c89a76c4f36af527f937c2f8cf4cad41 (diff)
downloadlinux-5ebab74a711388fc30e6d839eee79aa06d1ce0af.tar.gz
leds: lp5523: Fix return value
Return the value obtained from i2c_smbus_read_byte_data() instead of
-EIO. Silences the following smatch warning:
drivers/leds/leds-lp5523.c:174 lp5523_read() info:
why not propagate 'ret' from i2c_smbus_read_byte_data() instead of -5?

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds/leds-lp5523.c')
-rw-r--r--drivers/leds/leds-lp5523.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 59ec383900de..eb89cbd419ca 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -171,7 +171,7 @@ static int lp5523_read(struct i2c_client *client, u8 reg, u8 *buf)
 	s32 ret = i2c_smbus_read_byte_data(client, reg);
 
 	if (ret < 0)
-		return -EIO;
+		return ret;
 
 	*buf = ret;
 	return 0;