diff options
| author | Markus Elfring <elfring@users.sourceforge.net> | 2019-11-05 12:19:39 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2019-11-11 10:19:06 +0000 |
| commit | 761becb29183c4e2ad9ff5f63933170c8fffd544 (patch) | |
| tree | 3d5c39f98e0335d65a391f82e4caf987f2c5b900 /drivers/irqchip/irq-ti-sci-inta.c | |
| parent | b8b0145f7d0e24d98a58b7e54051dca0c1d77526 (diff) | |
| download | linux-761becb29183c4e2ad9ff5f63933170c8fffd544.tar.gz | |
irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))
A coccicheck run provided information like the following. drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used with vint_desc. Generated by: scripts/coccinelle/api/err_cast.cocci Thus adjust the exception handling in one if branch. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: Marc Zyngier <maz@kernel.org> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Link: https://lore.kernel.org/r/776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de
Diffstat (limited to 'drivers/irqchip/irq-ti-sci-inta.c')
| -rw-r--r-- | drivers/irqchip/irq-ti-sci-inta.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-ti-sci-inta.c b/drivers/irqchip/irq-ti-sci-inta.c index ef4d625d2d80..8f6e6b08eadf 100644 --- a/drivers/irqchip/irq-ti-sci-inta.c +++ b/drivers/irqchip/irq-ti-sci-inta.c @@ -246,8 +246,8 @@ static struct ti_sci_inta_event_desc *ti_sci_inta_alloc_irq(struct irq_domain *d /* No free bits available. Allocate a new vint */ vint_desc = ti_sci_inta_alloc_parent_irq(domain); if (IS_ERR(vint_desc)) { - mutex_unlock(&inta->vint_mutex); - return ERR_PTR(PTR_ERR(vint_desc)); + event_desc = ERR_CAST(vint_desc); + goto unlock; } free_bit = find_first_zero_bit(vint_desc->event_map, @@ -259,6 +259,7 @@ alloc_event: if (IS_ERR(event_desc)) clear_bit(free_bit, vint_desc->event_map); +unlock: mutex_unlock(&inta->vint_mutex); return event_desc; } |