summary refs log tree commit diff
path: root/drivers/iio/light
diff options
context:
space:
mode:
authorShreeya Patel <shreeya.patel@collabora.com>2022-08-26 17:53:52 +0530
committerJonathan Cameron <Jonathan.Cameron@huawei.com>2022-10-17 08:51:26 +0100
commit0dec4d2f2636b9e54d9d29f17afc7687c5407f78 (patch)
treee80f9fc92eb8315f625b6b69d6d6a4e2bff5d72c /drivers/iio/light
parent9abf2313adc1ca1b6180c508c25f22f9395cc780 (diff)
downloadlinux-0dec4d2f2636b9e54d9d29f17afc7687c5407f78.tar.gz
iio: light: tsl2583: Fix module unloading
tsl2583 probe() uses devm_iio_device_register() and calling
iio_device_unregister() causes the unregister to occur twice. s
Switch to iio_device_register() instead of devm_iio_device_register()
in probe to avoid the device managed cleanup.

Fixes: 371894f5d1a0 ("iio: tsl2583: add runtime power management support")
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Link: https://lore.kernel.org/r/20220826122352.288438-1-shreeya.patel@collabora.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Diffstat (limited to 'drivers/iio/light')
-rw-r--r--drivers/iio/light/tsl2583.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/iio/light/tsl2583.c b/drivers/iio/light/tsl2583.c
index 0a2ca1a8146d..7bcb5c718922 100644
--- a/drivers/iio/light/tsl2583.c
+++ b/drivers/iio/light/tsl2583.c
@@ -858,7 +858,7 @@ static int tsl2583_probe(struct i2c_client *clientp,
 					 TSL2583_POWER_OFF_DELAY_MS);
 	pm_runtime_use_autosuspend(&clientp->dev);
 
-	ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev);
+	ret = iio_device_register(indio_dev);
 	if (ret) {
 		dev_err(&clientp->dev, "%s: iio registration failed\n",
 			__func__);