summary refs log tree commit diff
path: root/drivers/hwmon/jz4740-hwmon.c
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2014-08-06 08:02:44 +0800
committerGuenter Roeck <linux@roeck-us.net>2014-08-05 19:40:15 -0700
commitd58e47d787c09fe5c61af3c6ce7d784762f29c3d (patch)
tree8b33435a10a87f535908ec344b38d25d3e960fdc /drivers/hwmon/jz4740-hwmon.c
parent539a719f9b90f37b934b90ad52be646b9e74a9f6 (diff)
downloadlinux-d58e47d787c09fe5c61af3c6ce7d784762f29c3d.tar.gz
hwmon: (dme1737) Prevent overflow problem when writing large limits
On platforms with sizeof(int) < sizeof(long), writing a temperature
limit larger than MAXINT will result in unpredictable limit values
written to the chip. Avoid auto-conversion from long to int to fix
the problem.

Voltage limits, fan minimum speed, pwm frequency, pwm ramp rate, and
other attributes have the same problem, fix them as well.

Zone temperature limits are signed, but were cached as u8, causing
unepected values to be reported for negative temperatures. Cache as
s8 to fix the problem.

vrm is an u8, so the written value needs to be limited to [0, 255].

Signed-off-by: Axel Lin <axel.lin@ingics.com>
[Guenter Roeck: Fix zone temperature cache]
Cc: stable@vger.kernel.org
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'drivers/hwmon/jz4740-hwmon.c')
0 files changed, 0 insertions, 0 deletions