summary refs log tree commit diff
path: root/drivers/hid/hid-semitek.c
diff options
context:
space:
mode:
authorChristian Marangi <ansuelsmth@gmail.com>2023-06-14 11:17:14 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-06-21 16:00:55 +0200
commit33965ac3409153d3f1af8039ad671b6b47dd0b2d (patch)
tree3ffe88f0de2c95036a4de309732a2159971b384c /drivers/hid/hid-semitek.c
parentbfaf388d359922d81e7e7f0551ebe9297d8da98e (diff)
downloadlinux-33965ac3409153d3f1af8039ad671b6b47dd0b2d.tar.gz
net: ethernet: stmicro: stmmac: fix possible memory leak in __stmmac_open
commit 30134b7c47bd28fdb4db4d12aef824e0579cfee4 upstream.

Fix a possible memory leak in __stmmac_open when stmmac_init_phy fails.
It's also needed to free everything allocated by stmmac_setup_dma_desc
and not just the dma_conf struct.

Drop free_dma_desc_resources from __stmmac_open and correctly call
free_dma_desc_resources on each user of __stmmac_open on error.

Reported-by: Jose Abreu <Jose.Abreu@synopsys.com>
Fixes: ba39b344e924 ("net: ethernet: stmicro: stmmac: generate stmmac dma conf before open")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Cc: stable@vger.kernel.org
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Jose Abreu <Jose.Abreu@synopsys.com>
Link: https://lore.kernel.org/r/20230614091714.15912-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/hid/hid-semitek.c')
0 files changed, 0 insertions, 0 deletions