diff options
| author | Matthew Auld <matthew.auld@intel.com> | 2022-11-08 10:32:38 +0000 |
|---|---|---|
| committer | Matthew Auld <matthew.auld@intel.com> | 2022-11-09 10:07:22 +0000 |
| commit | 8c94951560ef29c455043bf2dfa2275b011edc66 (patch) | |
| tree | f6c9dc6fe66e250c83e561718c10e12bd4058a46 /drivers/gpu/drm/vgem | |
| parent | ccb0e02787d0f80d0081c446aec3756dd8f7bfe0 (diff) | |
| download | linux-8c94951560ef29c455043bf2dfa2275b011edc66.tar.gz | |
drm/i915: use i915_sg_dma_sizes() for all backends
We rely on page_sizes.sg in setup_scratch_page() reporting the correct value if the underlying sgl is not contiguous, however in get_pages_internal() we are only looking at the layout of the created pages when calculating the sg_page_sizes, and not the final sgl, which could in theory be completely different. In such a situation we might incorrectly think we have a 64K scratch page, when it is actually only 4K or similar split over multiple non-contiguous entries, which could lead to broken behaviour when touching the scratch space within the padding of a 64K GTT page-table. For most of the other backends we already just call i915_sg_dma_sizes() on the final mapping, so rather just move that into __i915_gem_object_set_pages() to avoid such issues coming back to bite us later. v2: Update missing conversion in gvt Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Stuart Summers <stuart.summers@intel.com> Cc: Andrzej Hajda <andrzej.hajda@intel.com> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20221108103238.165447-1-matthew.auld@intel.com
Diffstat (limited to 'drivers/gpu/drm/vgem')
0 files changed, 0 insertions, 0 deletions