summary refs log tree commit diff
path: root/drivers/fpga/fpga-mgr.c
diff options
context:
space:
mode:
authorTom Rix <trix@redhat.com>2020-06-08 05:54:45 -0700
committerMoritz Fischer <mdf@kernel.org>2020-06-18 18:24:16 -0700
commit88aaab9218f87c7c32e5db93554cf110352c3c13 (patch)
treefdf1b8d8b84600aca79ab5f73ea9277c364c4983 /drivers/fpga/fpga-mgr.c
parente1d9ec3af3463c1721723f68403ee14214d0d2f6 (diff)
downloadlinux-88aaab9218f87c7c32e5db93554cf110352c3c13.tar.gz
fpga: Fix dead store fpga-mgr.c
Using clang's scan-build/view this issue was flagged in fpga-mgr.c

  drivers/fpga/fpga-mgr.c:585:3: warning: Value stored to 'ret' is never read [deadcode.DeadStores]
                  ret = id;

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Diffstat (limited to 'drivers/fpga/fpga-mgr.c')
-rw-r--r--drivers/fpga/fpga-mgr.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
index e05104f5e40c..f38bab01432e 100644
--- a/drivers/fpga/fpga-mgr.c
+++ b/drivers/fpga/fpga-mgr.c
@@ -581,10 +581,8 @@ struct fpga_manager *fpga_mgr_create(struct device *dev, const char *name,
 		return NULL;
 
 	id = ida_simple_get(&fpga_mgr_ida, 0, 0, GFP_KERNEL);
-	if (id < 0) {
-		ret = id;
+	if (id < 0)
 		goto error_kfree;
-	}
 
 	mutex_init(&mgr->ref_mutex);