diff options
| author | Gustavo A. R. Silva <gustavoars@kernel.org> | 2020-06-17 16:11:35 -0500 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-06-24 11:26:23 +0530 |
| commit | 999a32efed09d724c426568731c5691233d3a680 (patch) | |
| tree | 47624246be291b7d2636f84d84f624162c2b583b /drivers/dma/hisi_dma.c | |
| parent | 09c16edc5a3dc2bcfa8a93ddbeec59793e3b414d (diff) | |
| download | linux-999a32efed09d724c426568731c5691233d3a680.tar.gz | |
dmaengine: hisilicon: Use struct_size() in devm_kzalloc()
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes. This code was detected with the help of Coccinelle and, audited and fixed manually. Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> Reviewed-by: Zhou Wang <wangzhou1@hisilicon.com> Link: https://lore.kernel.org/r/20200617211135.GA8660@embeddedor Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/hisi_dma.c')
| -rw-r--r-- | drivers/dma/hisi_dma.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/drivers/dma/hisi_dma.c b/drivers/dma/hisi_dma.c index ed3619266a48..e1a958ae7925 100644 --- a/drivers/dma/hisi_dma.c +++ b/drivers/dma/hisi_dma.c @@ -511,7 +511,6 @@ static int hisi_dma_probe(struct pci_dev *pdev, const struct pci_device_id *id) struct device *dev = &pdev->dev; struct hisi_dma_dev *hdma_dev; struct dma_device *dma_dev; - size_t dev_size; int ret; ret = pcim_enable_device(pdev); @@ -534,9 +533,7 @@ static int hisi_dma_probe(struct pci_dev *pdev, const struct pci_device_id *id) if (ret) return ret; - dev_size = sizeof(struct hisi_dma_chan) * HISI_DMA_CHAN_NUM + - sizeof(*hdma_dev); - hdma_dev = devm_kzalloc(dev, dev_size, GFP_KERNEL); + hdma_dev = devm_kzalloc(dev, struct_size(hdma_dev, chan, HISI_DMA_CHAN_NUM), GFP_KERNEL); if (!hdma_dev) return -EINVAL; |