summary refs log tree commit diff
path: root/drivers/dma/at_hdmac.c
diff options
context:
space:
mode:
authorYong Wang <yong.y.wang@linux.intel.com>2010-08-05 10:40:08 +0800
committerDan Williams <dan.j.williams@intel.com>2010-08-04 22:09:17 -0700
commitb0ebeb9c09cb5b84bb2f33927c84c7648845fcec (patch)
tree3ebb434421ef49abe2bda85840db2834391fcbba /drivers/dma/at_hdmac.c
parent61cd2203769a2bf35d41f8682f6ef865fe2d23ff (diff)
downloadlinux-b0ebeb9c09cb5b84bb2f33927c84c7648845fcec.tar.gz
DMAENGINE: at_hdmac: locking fixlet
atc_chain_complete shall be called with atchan->lock held
and bh disabled.

Signed-off-by: Yong Wang <yong.y.wang@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma/at_hdmac.c')
-rw-r--r--drivers/dma/at_hdmac.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c
index bd5250e8c00c..646f6d6809f5 100644
--- a/drivers/dma/at_hdmac.c
+++ b/drivers/dma/at_hdmac.c
@@ -790,12 +790,12 @@ static int atc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd,
 	list_splice_init(&atchan->queue, &list);
 	list_splice_init(&atchan->active_list, &list);
 
-	spin_unlock_bh(&atchan->lock);
-
 	/* Flush all pending and queued descriptors */
 	list_for_each_entry_safe(desc, _desc, &list, desc_node)
 		atc_chain_complete(atchan, desc);
 
+	spin_unlock_bh(&atchan->lock);
+
 	return 0;
 }