diff options
| author | Liang He <windhl@126.com> | 2022-06-28 22:38:51 +0800 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-08-19 14:41:47 -0700 |
| commit | a8ea4273bc26256ce3cce83164f0f51c5bf6e127 (patch) | |
| tree | 3016318a44fdd5f338b74f9b0047bebeffb10314 /drivers/clk/clk-qoriq.c | |
| parent | 1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f (diff) | |
| download | linux-a8ea4273bc26256ce3cce83164f0f51c5bf6e127.tar.gz | |
clk: qoriq: Hold reference returned by of_get_parent()
In legacy_init_clockgen(), we need to hold the reference returned
by of_get_parent() and use it to call of_node_put() for refcount
balance.
Beside, in create_sysclk(), we need to call of_node_put() on 'sysclk'
also for refcount balance.
Fixes: 0dfc86b3173f ("clk: qoriq: Move chip-specific knowledge into driver")
Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220628143851.171299-1-windhl@126.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/clk-qoriq.c')
| -rw-r--r-- | drivers/clk/clk-qoriq.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/clk/clk-qoriq.c b/drivers/clk/clk-qoriq.c index 88898b97a443..5eddb9f0d6bd 100644 --- a/drivers/clk/clk-qoriq.c +++ b/drivers/clk/clk-qoriq.c @@ -1063,8 +1063,13 @@ static void __init _clockgen_init(struct device_node *np, bool legacy); */ static void __init legacy_init_clockgen(struct device_node *np) { - if (!clockgen.node) - _clockgen_init(of_get_parent(np), true); + if (!clockgen.node) { + struct device_node *parent_np; + + parent_np = of_get_parent(np); + _clockgen_init(parent_np, true); + of_node_put(parent_np); + } } /* Legacy node */ @@ -1159,6 +1164,7 @@ static struct clk * __init create_sysclk(const char *name) sysclk = of_get_child_by_name(clockgen.node, "sysclk"); if (sysclk) { clk = sysclk_from_fixed(sysclk, name); + of_node_put(sysclk); if (!IS_ERR(clk)) return clk; } |