summary refs log tree commit diff
path: root/crypto
diff options
context:
space:
mode:
authorMarcin Kozlowski <marcinguy@gmail.com>2022-04-06 10:05:37 +0200
committerDavid S. Miller <davem@davemloft.net>2022-04-06 15:22:49 +0100
commitafb8e246527536848b9b4025b40e613edf776a9d (patch)
treebba65f00616ac85cf4ab5c512261802781d2fd7e /crypto
parent4e910dbe36508654a896d5735b318c0b88172570 (diff)
downloadlinux-afb8e246527536848b9b4025b40e613edf776a9d.tar.gz
net: usb: aqc111: Fix out-of-bounds accesses in RX fixup
aqc111_rx_fixup() contains several out-of-bounds accesses that can be
triggered by a malicious (or defective) USB device, in particular:

 - The metadata array (desc_offset..desc_offset+2*pkt_count) can be out of bounds,
   causing OOB reads and (on big-endian systems) OOB endianness flips.
 - A packet can overlap the metadata array, causing a later OOB
   endianness flip to corrupt data used by a cloned SKB that has already
   been handed off into the network stack.
 - A packet SKB can be constructed whose tail is far beyond its end,
   causing out-of-bounds heap data to be considered part of the SKB's
   data.

Found doing variant analysis. Tested it with another driver (ax88179_178a), since
I don't have a aqc111 device to test it, but the code looks very similar.

Signed-off-by: Marcin Kozlowski <marcinguy@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'crypto')
0 files changed, 0 insertions, 0 deletions