summary refs log tree commit diff
path: root/crypto/testmgr.c
diff options
context:
space:
mode:
authorSimon Wunderlich <sw@simonwunderlich.de>2013-11-21 18:19:52 +0100
committerJohannes Berg <johannes.berg@intel.com>2013-12-02 11:51:54 +0100
commitbeffd138d358b69bf15f5a46cb18b31a9b37befb (patch)
tree42f8a1a5019060b18543852f049b9f9043c1159c /crypto/testmgr.c
parente487eaeb076a44c69dc61348cbc903151bb8fcbd (diff)
downloadlinux-beffd138d358b69bf15f5a46cb18b31a9b37befb.tar.gz
mac80211: don't cancel csa finalize work within stop_ap
The current channel switch code has a potential deadlock:
1) * cfg80211_stop_ap acquires wdev-lock
   * ieee80211_stop_ap calls cancel_work_sync for the csa_finalize_work,
     which acquires the associated worker-lock
2) * ieee80211_csa_finalize_work holds the worker-lock when run
   * it calls cfg80211_ch_switch_notify which will claim the wdev-lock,
     and also needs to claim the sdata-lock (which is the same as the
     wdev-lock) to modify the beacons.

It is sufficient to just set the channel switch active to false. If the
worker is running later, it will find the channel switch to not be
active anymore and returns immediately without changing anything.

Canceling the worker is done anyway when the interface goes down
(ieee80211_do_stop).

Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Diffstat (limited to 'crypto/testmgr.c')
0 files changed, 0 insertions, 0 deletions