summary refs log tree commit diff
path: root/block
diff options
context:
space:
mode:
authorJens Axboe <axboe@kernel.dk>2022-09-28 09:19:59 -0600
committerJens Axboe <axboe@kernel.dk>2022-09-30 07:48:00 -0600
commite73a625bc24880f1fe5abaa89bb63e0918fbd66c (patch)
tree95c4143f1744ff629599232d8e03abfaee538f0c /block
parent5853a7b5512c3017f64ca26494bd7361a12d6992 (diff)
downloadlinux-e73a625bc24880f1fe5abaa89bb63e0918fbd66c.tar.gz
block: kill deprecated BUG_ON() in the flush handling
We've never had any useful reports from this BUG_ON(), and in fact a
number of the BUG_ON()'s in the flush handling need to be turned into
more graceful handling.

In preparation for allowing batched completions of the end_io handling,
where we can enter the flush completion with queuelist having been reused
for the batch, get rid of this BUG_ON().

Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
-rw-r--r--block/blk-flush.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/block/blk-flush.c b/block/blk-flush.c
index d20a0c6b2c66..27705fc584a0 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -205,7 +205,6 @@ static void blk_flush_complete_seq(struct request *rq,
 		 * flush data request completion path.  Restore @rq for
 		 * normal completion and end it.
 		 */
-		BUG_ON(!list_empty(&rq->queuelist));
 		list_del_init(&rq->flush.list);
 		blk_flush_restore_request(rq);
 		blk_mq_end_request(rq, error);