summary refs log tree commit diff
path: root/block
diff options
context:
space:
mode:
authorDamien Le Moal <damien.lemoal@opensource.wdc.com>2022-06-02 21:03:44 +0900
committerJens Axboe <axboe@kernel.dk>2022-06-02 07:11:28 -0600
commitaacae8c469f9ce4b303a2eb61593ff522c1420bc (patch)
tree6493baa81013cfe7bf690157723e390eec42dcf6 /block
parentc9fdf7b453874e37ff4c499140ba2ab56fa0c7e5 (diff)
downloadlinux-aacae8c469f9ce4b303a2eb61593ff522c1420bc.tar.gz
block: null_blk: Fix null_zone_write()
The bio and rq fields of struct nullb_cmd are now overlapping in a
union. So we cannot use a test on ->bio being non-NULL to detect the
NULL_Q_BIO queue mode. null_zone_write() use such broken test to set the
sector position of a zone append write in the command bio or request.
When the null_blk device uses the NULL_Q_MQ queue mode,
null_zone_write() wrongly end up setting the bio sector position,
resulting in the command request to be broken and random crashes
following.

Fix this by testing the device queue mode directly.

Fixes: 8ba816b23abd ("null-blk: save memory footprint for struct nullb_cmd")
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/20220602120344.1365329-1-damien.lemoal@opensource.wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block')
0 files changed, 0 insertions, 0 deletions