summary refs log tree commit diff
path: root/block/blk-mq-cpumap.c
diff options
context:
space:
mode:
authorXianting Tian <tian.xianting@h3c.com>2020-10-19 16:20:47 +0800
committerJens Axboe <axboe@kernel.dk>2020-10-20 07:08:17 -0600
commit576e85c5e92486f1aa8be3cb1a30cb59d4415981 (patch)
tree3026de0e15160a6f1acbe5ebb1280de3c1633d5e /block/blk-mq-cpumap.c
parent0669d2b265d0f6f9e16f1abbf5c5d2e22b219a6b (diff)
downloadlinux-576e85c5e92486f1aa8be3cb1a30cb59d4415981.tar.gz
blk-mq: remove the calling of local_memory_node()
We don't need to check whether the node is memoryless numa node before
calling allocator interface. SLUB(and SLAB,SLOB) relies on the page
allocator to pick a node. Page allocator should deal with memoryless
nodes just fine. It has zonelists constructed for each possible nodes.
And it will automatically fall back into a node which is closest to the
requested node. As long as __GFP_THISNODE is not enforced of course.

The code comments of kmem_cache_alloc_node() of SLAB also showed this:
 * Fallback to other node is possible if __GFP_THISNODE is not set.

blk-mq code doesn't set __GFP_THISNODE, so we can remove the calling
of local_memory_node().

Signed-off-by: Xianting Tian <tian.xianting@h3c.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'block/blk-mq-cpumap.c')
-rw-r--r--block/blk-mq-cpumap.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/block/blk-mq-cpumap.c b/block/blk-mq-cpumap.c
index 0157f2b3485a..3db84d3197f1 100644
--- a/block/blk-mq-cpumap.c
+++ b/block/blk-mq-cpumap.c
@@ -89,7 +89,7 @@ int blk_mq_hw_queue_to_node(struct blk_mq_queue_map *qmap, unsigned int index)
 
 	for_each_possible_cpu(i) {
 		if (index == qmap->mq_map[i])
-			return local_memory_node(cpu_to_node(i));
+			return cpu_to_node(i);
 	}
 
 	return NUMA_NO_NODE;