summary refs log tree commit diff
path: root/arch/x86/kernel/nmi_32.c
diff options
context:
space:
mode:
authorIngo Molnar <mingo@elte.hu>2008-03-21 14:32:36 +0100
committerIngo Molnar <mingo@elte.hu>2008-04-17 17:41:21 +0200
commit6e908947b4995bc0e551a8257c586d5c3e428201 (patch)
tree62eeef1df8d45b4d02d69a235a472b31024de46d /arch/x86/kernel/nmi_32.c
parentf2e576b8141ec1cf2669ff7bbc92f0a9c147f34f (diff)
downloadlinux-6e908947b4995bc0e551a8257c586d5c3e428201.tar.gz
x86: fix ioapic bug again
un-revert:

 commit 4960c9df1407c2723459c60ff13e6efe0c209c62
 Author: Thomas Gleixner <tglx@linutronix.de>
 Date:   Tue Jan 22 10:23:01 2008 +0100

     Revert "x86: fix NMI watchdog & 'stopped time' problem"

         This reverts commit d4d25deca49ec2527a634557bf5a6cf449f85deb.

needs a proper fix though ...

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Diffstat (limited to 'arch/x86/kernel/nmi_32.c')
-rw-r--r--arch/x86/kernel/nmi_32.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/arch/x86/kernel/nmi_32.c b/arch/x86/kernel/nmi_32.c
index 662e63e1cd57..8421d0ac6f22 100644
--- a/arch/x86/kernel/nmi_32.c
+++ b/arch/x86/kernel/nmi_32.c
@@ -26,6 +26,7 @@
 
 #include <asm/smp.h>
 #include <asm/nmi.h>
+#include <asm/timer.h>
 
 #include "mach_traps.h"
 
@@ -81,7 +82,7 @@ int __init check_nmi_watchdog(void)
 
 	prev_nmi_count = kmalloc(NR_CPUS * sizeof(int), GFP_KERNEL);
 	if (!prev_nmi_count)
-		return -1;
+		goto error;
 
 	printk(KERN_INFO "Testing NMI watchdog ... ");
 
@@ -118,7 +119,7 @@ int __init check_nmi_watchdog(void)
 	if (!atomic_read(&nmi_active)) {
 		kfree(prev_nmi_count);
 		atomic_set(&nmi_active, -1);
-		return -1;
+		goto error;
 	}
 	printk("OK.\n");
 
@@ -129,6 +130,10 @@ int __init check_nmi_watchdog(void)
 
 	kfree(prev_nmi_count);
 	return 0;
+error:
+	timer_ack = !cpu_has_tsc;
+
+	return -1;
 }
 
 static int __init setup_nmi_watchdog(char *str)