summary refs log tree commit diff
path: root/arch/tile
diff options
context:
space:
mode:
authorChris Metcalf <cmetcalf@mellanox.com>2016-09-06 15:56:15 -0400
committerChris Metcalf <cmetcalf@mellanox.com>2016-12-16 15:32:29 -0500
commit870ee4ff5647dbf024f99ba5e56d0f3c344f1511 (patch)
treeeb252d40e4916b6fdae14272b18c95c1a46344e7 /arch/tile
parent8e36f722f73f2fc1766af1af0b2f56f2299ba687 (diff)
downloadlinux-870ee4ff5647dbf024f99ba5e56d0f3c344f1511.tar.gz
tile: remove #pragma unroll from finv_buffer_remote()
This directive was put in the kernel source before the "pragma
unroll" support for tilegx gcc was upstreamed.  Remove it for
now, and we can put it back later if/when the compiler support
is upstreamed.  This avoids a warning when building the kernel.

This routine is not on a hot path in any case, so the extra
optimization here was mostly just for its own sake.

Signed-off-by: Chris Metcalf <cmetcalf@mellanox.com>
Diffstat (limited to 'arch/tile')
-rw-r--r--arch/tile/lib/cacheflush.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/arch/tile/lib/cacheflush.c b/arch/tile/lib/cacheflush.c
index 9c0ec22009a5..c1ebc1065fc1 100644
--- a/arch/tile/lib/cacheflush.c
+++ b/arch/tile/lib/cacheflush.c
@@ -138,19 +138,13 @@ finv_buffer_remote(void *buffer, size_t size, int hfh)
 	if ((unsigned long)base < (unsigned long)buffer)
 		base = buffer;
 
-	/*
-	 * Fire all the loads we need.  The MAF only has eight entries
-	 * so we can have at most eight outstanding loads, so we
-	 * unroll by that amount.
-	 */
-#pragma unroll 8
+	/* Fire all the loads we need. */
 	for (; p >= base; p -= step_size)
 		force_load(p);
 
 	/*
 	 * Repeat, but with finv's instead of loads, to get rid of the
 	 * data we just loaded into our own cache and the old home L3.
-	 * No need to unroll since finv's don't target a register.
 	 * The finv's are guaranteed not to actually flush the data in
 	 * the buffer back to their home, since we just read it, so the
 	 * lines are clean in cache; we will only invalidate those lines.