summary refs log tree commit diff
path: root/arch/mips/Makefile
diff options
context:
space:
mode:
authorH. Nikolaus Schaller <hns@goldelico.com>2021-07-08 10:57:09 +0200
committerMasahiro Yamada <masahiroy@kernel.org>2021-08-05 20:51:11 +0900
commitfa953adfad7cf9c7e30d9ea0e4ccfd38cfb5495d (patch)
treef428e613bb303896f583a45c6454d3acfac96186 /arch/mips/Makefile
parentc500bee1c5b2f1d59b1081ac879d73268ab0ff17 (diff)
downloadlinux-fa953adfad7cf9c7e30d9ea0e4ccfd38cfb5495d.tar.gz
x86/tools/relocs: Fix non-POSIX regexp
Trying to run a cross-compiled x86 relocs tool on a BSD based
HOSTCC leads to errors like

  VOFFSET arch/x86/boot/compressed/../voffset.h - due to: vmlinux
  CC      arch/x86/boot/compressed/misc.o - due to: arch/x86/boot/compressed/../voffset.h
  OBJCOPY arch/x86/boot/compressed/vmlinux.bin - due to: vmlinux
  RELOCS  arch/x86/boot/compressed/vmlinux.relocs - due to: vmlinux
empty (sub)expressionarch/x86/boot/compressed/Makefile:118: recipe for target 'arch/x86/boot/compressed/vmlinux.relocs' failed
make[3]: *** [arch/x86/boot/compressed/vmlinux.relocs] Error 1

It turns out that relocs.c uses patterns like

	"something(|_end)"

This is not valid syntax or gives undefined results according
to POSIX 9.5.3 ERE Grammar

	https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap09.html

It seems to be silently accepted by the Linux regexp() implementation
while a BSD host complains.

Such patterns can be replaced by a transformation like

	"(|p1|p2)" -> "(p1|p2)?"

Fixes: fd952815307f ("x86-32, relocs: Whitelist more symbols for ld bug workaround")
Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Diffstat (limited to 'arch/mips/Makefile')
0 files changed, 0 insertions, 0 deletions