diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2022-04-28 11:11:35 +0200 |
|---|---|---|
| committer | Arnd Bergmann <arnd@arndb.de> | 2022-04-29 09:53:28 +0200 |
| commit | e514f1fd09b6f966f5f55220fdc4fb8a2efc0d6a (patch) | |
| tree | 9f826b72b567b158421c986cc27bf50b1daa0d6c /arch/arm/mach-omap1 | |
| parent | deb44711675efa923ee8cebc0c5730d6f5905b32 (diff) | |
| download | linux-e514f1fd09b6f966f5f55220fdc4fb8a2efc0d6a.tar.gz | |
ARM: omap: fix missing declaration warnings
Moving the plat-omap files triggered a sparse warning for omap1 and omap2 that is now in a different file from before. Found some more sparse warnings here that I address by making sure the declaration is visible to both the caller and the callee, or they are static mach-omap1/fb.c:33:17: warning: symbol 'omap_fb_resources' was not declared. Should it be static? mach-omap1/timer32k.c:215:12: warning: symbol 'omap_init_clocksource_32k' was not declared. Should it be static? mach-omap1/i2c.c:36:12: warning: symbol 'omap_i2c_add_bus' was not declared. Should it be static? mach-omap1/i2c.c:115:12: warning: symbol 'omap_register_i2c_bus_cmdline' was not declared. Should it be static? mach-omap1/i2c.c:140:12: warning: symbol 'omap_register_i2c_bus' was not declared. Should it be static? mach-omap2/dma.c:180:34: warning: symbol 'dma_plat_info' was not declared. Should it be static? mach-omap2/omap4-common.c:116:6: warning: symbol 'omap_interconnect_sync' was not declared. Should it be static? mach-omap2/omap-iommu.c:113:5: warning: symbol 'omap_iommu_set_pwrdm_constraint' was not declared. Should it be static? Reported-by: kernel test robot <lkp@intel.com> Reviewed-by: Tony Lindgren <tony@atomide.com> Tested-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Diffstat (limited to 'arch/arm/mach-omap1')
| -rw-r--r-- | arch/arm/mach-omap1/fb.c | 2 | ||||
| -rw-r--r-- | arch/arm/mach-omap1/i2c.c | 1 | ||||
| -rw-r--r-- | arch/arm/mach-omap1/timer32k.c | 2 |
3 files changed, 3 insertions, 2 deletions
diff --git a/arch/arm/mach-omap1/fb.c b/arch/arm/mach-omap1/fb.c index a4538c231f66..b6e952b03838 100644 --- a/arch/arm/mach-omap1/fb.c +++ b/arch/arm/mach-omap1/fb.c @@ -30,7 +30,7 @@ static struct omapfb_platform_data omapfb_config; static u64 omap_fb_dma_mask = ~(u32)0; -struct resource omap_fb_resources[] = { +static struct resource omap_fb_resources[] = { { .name = "irq", .start = INT_LCD_CTRL, diff --git a/arch/arm/mach-omap1/i2c.c b/arch/arm/mach-omap1/i2c.c index f574eb0bcc0b..22f945360599 100644 --- a/arch/arm/mach-omap1/i2c.c +++ b/arch/arm/mach-omap1/i2c.c @@ -10,6 +10,7 @@ #include "mux.h" #include "soc.h" +#include "i2c.h" #define OMAP_I2C_SIZE 0x3f #define OMAP1_I2C_BASE 0xfffb3800 diff --git a/arch/arm/mach-omap1/timer32k.c b/arch/arm/mach-omap1/timer32k.c index 560cd16568a7..410d17d1d443 100644 --- a/arch/arm/mach-omap1/timer32k.c +++ b/arch/arm/mach-omap1/timer32k.c @@ -212,7 +212,7 @@ static void omap_read_persistent_clock64(struct timespec64 *ts) * Returns 0 upon success or negative error code upon failure. * */ -int __init omap_init_clocksource_32k(void __iomem *vbase) +static int __init omap_init_clocksource_32k(void __iomem *vbase) { int ret; |