summary refs log tree commit diff
diff options
context:
space:
mode:
authorYang Yingliang <yangyingliang@huawei.com>2021-04-01 12:26:07 +0200
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>2021-04-06 16:09:00 +0200
commitd21ffd937a3fb91d87fbec62bb8d0422c536536a (patch)
treeeb0dc9a82cd47cd83e9014cafa8285b92a9626b4
parent92eda6b7dad6372cd35f13560cad980cf2f6485a (diff)
downloadlinux-d21ffd937a3fb91d87fbec62bb8d0422c536536a.tar.gz
media: imx-pxp: remove redundant dev_err call in pxp_probe()
There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
-rw-r--r--drivers/media/platform/imx-pxp.c7
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/media/platform/imx-pxp.c b/drivers/media/platform/imx-pxp.c
index 078d19afe35f..4321edc0c23d 100644
--- a/drivers/media/platform/imx-pxp.c
+++ b/drivers/media/platform/imx-pxp.c
@@ -1654,11 +1654,8 @@ static int pxp_probe(struct platform_device *pdev)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	dev->mmio = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(dev->mmio)) {
-		ret = PTR_ERR(dev->mmio);
-		dev_err(&pdev->dev, "Failed to map register space: %d\n", ret);
-		return ret;
-	}
+	if (IS_ERR(dev->mmio))
+		return PTR_ERR(dev->mmio);
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0)