summary refs log tree commit diff
diff options
context:
space:
mode:
authorSun Ke <sunke32@huawei.com>2022-09-20 10:00:41 +0800
committerPaolo Abeni <pabeni@redhat.com>2022-09-22 12:25:59 +0200
commit9b17dbd97de78796997583340b540bdb571694e6 (patch)
treecda51c11347e80bb0e5f5d0bbd051d47083d020b
parent7a5d48c4463e6ef896ea2190a97d9e90b37c38da (diff)
downloadlinux-9b17dbd97de78796997583340b540bdb571694e6.tar.gz
net: ethernet: altera: TSE: fix error return code in altera_tse_probe()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: fef2998203e1 ("net: altera: tse: convert to phylink")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Sun Ke <sunke32@huawei.com>
Link: https://lore.kernel.org/r/20220920020041.2685948-1-sunke32@huawei.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
-rw-r--r--drivers/net/ethernet/altera/altera_tse_main.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
index 89ae6d1623aa..3cf409bdb283 100644
--- a/drivers/net/ethernet/altera/altera_tse_main.c
+++ b/drivers/net/ethernet/altera/altera_tse_main.c
@@ -1411,6 +1411,7 @@ static int altera_tse_probe(struct platform_device *pdev)
 				       priv->phy_iface, &alt_tse_phylink_ops);
 	if (IS_ERR(priv->phylink)) {
 		dev_err(&pdev->dev, "failed to create phylink\n");
+		ret = PTR_ERR(priv->phylink);
 		goto err_init_phy;
 	}