summary refs log tree commit diff
diff options
context:
space:
mode:
authorMing Lei <ming.lei@redhat.com>2022-08-23 18:38:19 +0800
committerJens Axboe <axboe@kernel.dk>2022-09-03 11:29:03 -0600
commit748008e1da926a814cc0a054c81ca614408b1b0c (patch)
tree8592062c8d7b3593d507e276db016a651cb835be
parent7a3d2225f1ae9e591fefd65c3bb1715dc54d96f1 (diff)
downloadlinux-748008e1da926a814cc0a054c81ca614408b1b0c.tar.gz
block: don't add partitions if GD_SUPPRESS_PART_SCAN is set
Commit b9684a71fca7 ("block, loop: support partitions without scanning")
adds GD_SUPPRESS_PART_SCAN for replacing part function of
GENHD_FL_NO_PART. But looks blk_add_partitions() is missed, since
loop doesn't want to add partitions if GENHD_FL_NO_PART was set.
And it causes regression on libblockdev (as called from udisks) which
operates with the LO_FLAGS_PARTSCAN.

Fixes the issue by not adding partitions if GD_SUPPRESS_PART_SCAN is
set.

Fixes: b9684a71fca7 ("block, loop: support partitions without scanning")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220823103819.395776-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
-rw-r--r--block/partitions/core.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/block/partitions/core.c b/block/partitions/core.c
index fc1d70384825..b8112f52d388 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -596,6 +596,9 @@ static int blk_add_partitions(struct gendisk *disk)
 	if (disk->flags & GENHD_FL_NO_PART)
 		return 0;
 
+	if (test_bit(GD_SUPPRESS_PART_SCAN, &disk->state))
+		return 0;
+
 	state = check_partition(disk);
 	if (!state)
 		return 0;