diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2022-06-28 11:31:34 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2022-06-28 21:23:30 -0700 |
| commit | 53ad46169fe2996fe1b623ba6c9c4fa33847876f (patch) | |
| tree | d73f1c9c08425f984032af3f026f9a6b5d6e8ea5 | |
| parent | adabdd8f6acabc0c3fdbba2e7f5a2edd9c5ef22d (diff) | |
| download | linux-53ad46169fe2996fe1b623ba6c9c4fa33847876f.tar.gz | |
net: ipv6: unexport __init-annotated seg6_hmac_net_init()
As of commit 5801f064e351 ("net: ipv6: unexport __init-annotated seg6_hmac_init()"),
EXPORT_SYMBOL and __init is a bad combination because the .init.text
section is freed up after the initialization. Hence, modules cannot
use symbols annotated __init. The access to a freed symbol may end up
with kernel panic.
This remove the EXPORT_SYMBOL to fix modpost warning:
WARNING: modpost: vmlinux.o(___ksymtab+seg6_hmac_net_init+0x0): Section mismatch in reference from the variable __ksymtab_seg6_hmac_net_init to the function .init.text:seg6_hmac_net_init()
The symbol seg6_hmac_net_init is exported and annotated __init
Fix this by removing the __init annotation of seg6_hmac_net_init or drop the export.
Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Link: https://lore.kernel.org/r/20220628033134.21088-1-yuehaibing@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
| -rw-r--r-- | net/ipv6/seg6_hmac.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/ipv6/seg6_hmac.c b/net/ipv6/seg6_hmac.c index 6de01185cc68..d43c50a7310d 100644 --- a/net/ipv6/seg6_hmac.c +++ b/net/ipv6/seg6_hmac.c @@ -406,7 +406,6 @@ int __net_init seg6_hmac_net_init(struct net *net) return rhashtable_init(&sdata->hmac_infos, &rht_params); } -EXPORT_SYMBOL(seg6_hmac_net_init); void seg6_hmac_exit(void) { |