diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-09-15 17:13:34 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@kernel.org> | 2022-09-19 13:09:23 +0300 |
| commit | 4c3140f4cea66b06e4a982e0c2f7b7d113040b26 (patch) | |
| tree | d808197ee1937d78f5a2920e0fbd2ab0e0abb816 | |
| parent | f2c6e7ca3ee6ebb0a9562f3c0f6d09f15eaed4ed (diff) | |
| download | linux-4c3140f4cea66b06e4a982e0c2f7b7d113040b26.tar.gz | |
wifi: rtw89: uninitialized variable on error in rtw89_early_fw_feature_recognize()
If request_partial_firmware_into_buf() fails then "firmware" is not
initialized and the release_firmware(firmware) will crash.
Fixes: deebea35d699 ("wifi: rtw89: early recognize FW feature to decide if chanctx")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/YyMzDtX/3fUBnonC@kili
| -rw-r--r-- | drivers/net/wireless/realtek/rtw89/fw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/wireless/realtek/rtw89/fw.c b/drivers/net/wireless/realtek/rtw89/fw.c index 04fee40b062a..5e65f2c410bf 100644 --- a/drivers/net/wireless/realtek/rtw89/fw.c +++ b/drivers/net/wireless/realtek/rtw89/fw.c @@ -271,7 +271,7 @@ void rtw89_early_fw_feature_recognize(struct device *device, device, &buf, sizeof(buf), 0); if (ret) { dev_err(device, "failed to early request firmware: %d\n", ret); - goto out; + return; } ver_code = buf.mfw_hdr.sig != RTW89_MFW_SIG ? |