diff options
| author | Miaohe Lin <linmiaohe@huawei.com> | 2022-05-19 14:08:51 -0700 |
|---|---|---|
| committer | akpm <akpm@linux-foundation.org> | 2022-05-19 14:08:51 -0700 |
| commit | dab8dfff49a673a4b070ad3f44534b3c0e88a189 (patch) | |
| tree | 67c673013b8adc9e0849ff42d6561d14522cf3e1 | |
| parent | f19c25684c3e19b329e0498dd6d601df13c33223 (diff) | |
| download | linux-dab8dfff49a673a4b070ad3f44534b3c0e88a189.tar.gz | |
mm/swap: remove unneeded p != NULL check in __swap_duplicate
If p is NULL, __swap_duplicate will already return -EINVAL. So if we reach here, p must be non-NULL. Link: https://lkml.kernel.org/r/20220509131416.17553-8-linmiaohe@huawei.com Signed-off-by: Miaohe Lin <linmiaohe@huawei.com> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Oscar Salvador <osalvador@suse.de> Cc: Alistair Popple <apopple@nvidia.com> Cc: David Howells <dhowells@redhat.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: Naoya Horiguchi <naoya.horiguchi@nec.com> Cc: NeilBrown <neilb@suse.de> Cc: Peter Xu <peterx@redhat.com> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Vlastimil Babka <vbabka@suse.cz> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
| -rw-r--r-- | mm/swapfile.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/mm/swapfile.c b/mm/swapfile.c index f59abca5cea9..e67addac61e2 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -3333,8 +3333,7 @@ static int __swap_duplicate(swp_entry_t entry, unsigned char usage) unlock_out: unlock_cluster_or_swap_info(p, ci); - if (p) - put_swap_device(p); + put_swap_device(p); return err; } |