summary refs log tree commit diff
diff options
context:
space:
mode:
authorXiang Yang <xiangyang3@huawei.com>2022-11-15 15:32:25 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-03-11 13:55:19 +0100
commitc8583b4655aab44a9796b5c4a681ddcc6fe2f0d0 (patch)
tree92424949f7235e42271146fd22f37b65969bcd3a
parent14e8bd4cfae3ffc921c64130777cdd1c7a2267c3 (diff)
downloadlinux-c8583b4655aab44a9796b5c4a681ddcc6fe2f0d0.tar.gz
um: vector: Fix memory leak in vector_config
[ Upstream commit 8f88c73afe481f93d40801596927e8c0047b6d96 ]

If the return value of the uml_parse_vector_ifspec function is NULL,
we should call kfree(params) to prevent memory leak.

Fixes: 49da7e64f33e ("High Performance UML Vector Network Driver")
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
Acked-By: Anton Ivanov <anton.ivanov@kot-begemot.co.uk>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Sasha Levin <sashal@kernel.org>
-rw-r--r--arch/um/drivers/vector_kern.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/um/drivers/vector_kern.c b/arch/um/drivers/vector_kern.c
index ded7c47d2fbe..131b7cb29576 100644
--- a/arch/um/drivers/vector_kern.c
+++ b/arch/um/drivers/vector_kern.c
@@ -767,6 +767,7 @@ static int vector_config(char *str, char **error_out)
 
 	if (parsed == NULL) {
 		*error_out = "vector_config failed to parse parameters";
+		kfree(params);
 		return -EINVAL;
 	}