summary refs log tree commit diff
diff options
context:
space:
mode:
authorLyude Paul <lyude@redhat.com>2020-04-06 16:06:41 -0400
committerLyude Paul <lyude@redhat.com>2020-04-07 14:30:13 -0400
commit75727b30809266decfe21ed1143ef5cfd27bac89 (patch)
tree74c6fc5376facb8004e3028c72d789bdaf229741
parent7606662686154d28d53b5acd41fc8678aefaec71 (diff)
downloadlinux-75727b30809266decfe21ed1143ef5cfd27bac89.tar.gz
drm/i915/dp_mst: Cast intel_connector->port as drm_dp_mst_port
The only reason for having this cast as void * before was because we
originally needed to use drm_dp_mst_get_port_validated() and friends in
order to (attempt to) safely access MST ports. However, we've since
improved how reference counting works with ports and mstbs such that we
can now rely on drm_dp_mst_port structs remaining in memory for as long
as the driver needs. This means we don't really need to cast this as
void* anymore, and can just access the struct directly.

We'll also need this for the next commit, so that we can remove
drm_dp_mst_port_has_audio().

Signed-off-by: Lyude Paul <lyude@redhat.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200406200646.1263435-1-lyude@redhat.com
-rw-r--r--drivers/gpu/drm/i915/display/intel_display_types.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
index 5e00e611f077..e67474a71761 100644
--- a/drivers/gpu/drm/i915/display/intel_display_types.h
+++ b/drivers/gpu/drm/i915/display/intel_display_types.h
@@ -429,7 +429,7 @@ struct intel_connector {
 	   state of connector->polled in case hotplug storm detection changes it */
 	u8 polled;
 
-	void *port; /* store this opaque as its illegal to dereference it */
+	struct drm_dp_mst_port *port;
 
 	struct intel_dp *mst_port;