diff options
| author | Xin Long <lucien.xin@gmail.com> | 2017-04-06 13:10:52 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-06 13:55:51 -0700 |
| commit | 34b2789f1d9bf8dcca9b5cb553d076ca2cd898ee (patch) | |
| tree | a85b3cd3e8a87fcc1ed9c5cdce8ce8facce83525 | |
| parent | 6c22fce07c97f765af1808ec3be007847e0b47d1 (diff) | |
| download | linux-34b2789f1d9bf8dcca9b5cb553d076ca2cd898ee.tar.gz | |
sctp: listen on the sock only when it's state is listening or closed
Now sctp doesn't check sock's state before listening on it. It could even cause changing a sock with any state to become a listening sock when doing sctp_listen. This patch is to fix it by checking sock's state in sctp_listen, so that it will listen on the sock with right state. Reported-by: Andrey Konovalov <andreyknvl@google.com> Tested-by: Andrey Konovalov <andreyknvl@google.com> Signed-off-by: Xin Long <lucien.xin@gmail.com> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sctp/socket.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/net/sctp/socket.c b/net/sctp/socket.c index c1401f43d40f..d9d4c92e06b3 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -7034,6 +7034,9 @@ int sctp_inet_listen(struct socket *sock, int backlog) if (sock->state != SS_UNCONNECTED) goto out; + if (!sctp_sstate(sk, LISTENING) && !sctp_sstate(sk, CLOSED)) + goto out; + /* If backlog is zero, disable listening. */ if (!backlog) { if (sctp_sstate(sk, CLOSED)) |