summary refs log tree commit diff
diff options
context:
space:
mode:
authorMichael Ellerman <michael@ellerman.id.au>2006-03-16 14:47:20 +1100
committerPaul Mackerras <paulus@samba.org>2006-03-17 13:28:24 +1100
commit2c276603c3e5ebf38155a9d1fbbda656d52d138e (patch)
tree8f382336491425b0efef4a00b77c81f89ce8cd46
parent9b15879aefe6a4c2236297df68c46498af26143d (diff)
downloadlinux-2c276603c3e5ebf38155a9d1fbbda656d52d138e.tar.gz
[PATCH] powerpc: Fix bug in bug fix for bug in lmb_alloc()
My patch (d7a5b2ffa1352f0310630934a56aecbdfb617b72) to always panic if
lmb_alloc() fails is broken because it checks alloc < 0, but should be
checking alloc == 0.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
-rw-r--r--arch/powerpc/mm/lmb.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/powerpc/mm/lmb.c b/arch/powerpc/mm/lmb.c
index 874cd103ce6e..417d58518558 100644
--- a/arch/powerpc/mm/lmb.c
+++ b/arch/powerpc/mm/lmb.c
@@ -232,7 +232,7 @@ unsigned long __init lmb_alloc_base(unsigned long size, unsigned long align,
 
 	alloc = __lmb_alloc_base(size, align, max_addr);
 
-	if (alloc < 0)
+	if (alloc == 0)
 		panic("ERROR: Failed to allocate 0x%lx bytes below 0x%lx.\n",
 				size, max_addr);