summary refs log tree commit diff
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2021-07-20 17:17:07 +0100
committerTakashi Iwai <tiwai@suse.de>2021-07-20 18:22:29 +0200
commitdca18a94d3ad94201183f64d89149553c9cec95d (patch)
tree1343e146bf9c4bfdb4759d74dd9cbcc62b5ecd85
parente24ef4881bdd11c13d35235a410571c0d0aa0e5d (diff)
downloadlinux-dca18a94d3ad94201183f64d89149553c9cec95d.tar.gz
ALSA: sc6000: Fix incorrect sizeof operator
Static analysis is warning that the sizeof being used is should be
of *vport and not vport. Although these are the same size it is not
a portable assumption to assume this is true for all cases.  Fix this
by using sizeof(*vport).

Addresses-Coverity: ("Sizeof not portable")
Fixes: 111601ff76e9 ("ALSA: sc6000: Allocate resources with device-managed APIs")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210720161707.74197-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r--sound/isa/sc6000.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/isa/sc6000.c b/sound/isa/sc6000.c
index 6236c4fa766a..44c05b55fc15 100644
--- a/sound/isa/sc6000.c
+++ b/sound/isa/sc6000.c
@@ -552,7 +552,7 @@ static int snd_sc6000_probe(struct device *devptr, unsigned int dev)
 
 
 	err = snd_devm_card_new(devptr, index[dev], id[dev], THIS_MODULE,
-				sizeof(vport), &card);
+				sizeof(*vport), &card);
 	if (err < 0)
 		return err;