diff options
| author | Omar Sandoval <osandov@fb.com> | 2020-04-16 14:46:15 -0700 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2020-05-25 11:25:25 +0200 |
| commit | f337bd7478178f4c5e2b825fdb8dfaa266c344a2 (patch) | |
| tree | 5657afbbd6ed2d1e7a3b48edd964e4e742ceb801 | |
| parent | c7333972b9b571a03bf9aecd1aeecfab81243e8d (diff) | |
| download | linux-f337bd7478178f4c5e2b825fdb8dfaa266c344a2.tar.gz | |
btrfs: don't do repair validation for checksum errors
The purpose of the validation step is to distinguish between good and bad sectors in a failed multi-sector read. If a multi-sector read succeeded but some of those sectors had checksum errors, we don't need to validate anything; we know the sectors with bad checksums need to be repaired. Reviewed-by: Josef Bacik <josef@toxicpanda.com> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com> Signed-off-by: Omar Sandoval <osandov@fb.com> Signed-off-by: David Sterba <dsterba@suse.com>
| -rw-r--r-- | fs/btrfs/extent_io.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c index fcf2ff9ae4a8..cf24b2855462 100644 --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2641,6 +2641,14 @@ static bool btrfs_io_needs_validation(struct inode *inode, struct bio *bio) int i; /* + * If bi_status is BLK_STS_OK, then this was a checksum error, not an + * I/O error. In this case, we already know exactly which sector was + * bad, so we don't need to validate. + */ + if (bio->bi_status == BLK_STS_OK) + return false; + + /* * We need to validate each sector individually if the failed I/O was * for multiple sectors. */ |