summary refs log tree commit diff
diff options
context:
space:
mode:
authorAndrew Price <anprice@redhat.com>2012-10-12 16:45:08 +0100
committerSteven Whitehouse <swhiteho@redhat.com>2012-11-07 09:40:05 +0000
commitaaaf68c5629108f6078ab458d34a661143ea6857 (patch)
tree9a5e5a44d4aee71d25af98fac75cd689db41e6ff
parentddffeb8c4d0331609ef2581d84de4d763607bd37 (diff)
downloadlinux-aaaf68c5629108f6078ab458d34a661143ea6857.tar.gz
GFS2: Fix an unchecked error from gfs2_rs_alloc
Check the return value of gfs2_rs_alloc(ip) and avoid a possible null
pointer dereference.

Signed-off-by: Andrew Price <anprice@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
-rw-r--r--fs/gfs2/quota.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/fs/gfs2/quota.c b/fs/gfs2/quota.c
index 40c4b0d42fa8..c5af8e18f27a 100644
--- a/fs/gfs2/quota.c
+++ b/fs/gfs2/quota.c
@@ -497,8 +497,11 @@ int gfs2_quota_hold(struct gfs2_inode *ip, u32 uid, u32 gid)
 	struct gfs2_quota_data **qd;
 	int error;
 
-	if (ip->i_res == NULL)
-		gfs2_rs_alloc(ip);
+	if (ip->i_res == NULL) {
+		error = gfs2_rs_alloc(ip);
+		if (error)
+			return error;
+	}
 
 	qd = ip->i_res->rs_qa_qd;