summary refs log tree commit diff
diff options
context:
space:
mode:
authorJulia Lawall <julia@diku.dk>2011-06-01 19:10:05 +0200
committerMark Brown <broonie@opensource.wolfsonmicro.com>2011-06-01 19:20:22 +0100
commita2dc56c8a0009ba3879a26dfe416fc453fa2e32f (patch)
tree06ad134e442e9671b62bb5639a9eaebfdc8ed16f
parenta1e9adc00e722b8ec7d9b3d68e6f9564b9455d2f (diff)
downloadlinux-a2dc56c8a0009ba3879a26dfe416fc453fa2e32f.tar.gz
ASoC: add missing clk_put to nuc900-ac97
This goto is after the call to clk_get, so it should go to the label that
includes a call to clk_put.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2;
statement S;
@@

e1 = clk_get@p1(...);
... when != e1 = e2
    when != clk_put(e1)
    when any
if (...) { ... when != clk_put(e1)
               when != if (...) { ... clk_put(e1) ... }
* return@p3 ...;
 } else S
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
-rw-r--r--sound/soc/nuc900/nuc900-ac97.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sound/soc/nuc900/nuc900-ac97.c b/sound/soc/nuc900/nuc900-ac97.c
index dac6732da969..9c0edad90d8b 100644
--- a/sound/soc/nuc900/nuc900-ac97.c
+++ b/sound/soc/nuc900/nuc900-ac97.c
@@ -356,7 +356,7 @@ static int __devinit nuc900_ac97_drvprobe(struct platform_device *pdev)
 	nuc900_audio->irq_num = platform_get_irq(pdev, 0);
 	if (!nuc900_audio->irq_num) {
 		ret = -EBUSY;
-		goto out2;
+		goto out3;
 	}
 
 	nuc900_ac97_data = nuc900_audio;